Add OpenAPI task implementation #804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna add more tests soon |
fjtirado
reviewed
Sep 23, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/ExpressionURISupplier.java
Show resolved
Hide resolved
fjtirado
reviewed
Oct 6, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Oct 6, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Oct 10, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/HttpCallAdapter.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Oct 10, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Closed
fjtirado
reviewed
Oct 15, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutor.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Oct 16, 2025
Comment on lines
+75
to
+77
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
You do not need this block, you just want to propagate all exception that are not workflow (because if it workflow you want to try the next server), which will happen anyway if you delete this block
improve ExpressionURISupplier Signed-off-by: Dmitrii Tikhomirov <[email protected]>
fjtirado
approved these changes
Oct 16, 2025
|
Hi @treblereel, nice pull request! I would like to mention the redirect option, are you planning to do in another pull request? |
|
To be more specific, this one https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#properties-6 redirect |
|
@mcruzdev OpenAPI is quite a large topic, and I prefer to work on it in small iterations. It makes reviewing and testing easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Fix #477
Special notes for reviewers:
Additional information (if needed):]